-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling HDFS upgrade #571
Rolling HDFS upgrade #571
Conversation
…ically advance it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few typos and non-blocking thoughts and questions
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Moving back into RfC phase since 10e5220 adds a new |
I didn't see the new field in the CRD YAML. |
My bad, forgot to make crds. a9809ba |
We could probably move it back to voting to speed it up. |
TLDR pub struct HdfsClusterStatus {
/// The product version that the HDFS cluster is currently running.
///
/// During upgrades, this field contains the *old* version.
pub deployed_product_version: Option<String>,
/// The product version that is currently being upgraded to, otherwise null.
pub upgrading_product_version: Option<String>,
} Which works for me. WDYT of using |
Sounds like an improvement to me. |
Moving back into voting. Please vote on this comment. |
Voting finished, accepted |
Current merge blockers are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Co-authored-by: Nick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now so that when the last comment is answered/resolved, this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #362, currently implements the "manual" process from #362 (comment).
Definition of Done Checklist
Author
Reviewer
Acceptance